I’m pretty new here, but let me say that questions like this are not ignorant, at least not in my opinion.
The resistor value is really used to set the current through the LED. If you change out the LED to one with a different voltage drop, it means the current will also change (assuming the resistor stays the same). So in the end, it generally will still work. What you might need to do is change the resistor to get the appropriate brightness you are looking for.
Going to a higher resistor value will make the LED dimmer, and make the drain on the battery less. Of course the opposite is true as well.
You can do the following equation to estimate the drains on your battery:
(battery voltage - LED voltage drop) / (switch LED resistor + driver bypass resistor) = current
For my convoy S2+ build, I tried the following configurations using the switch from banggood linked above:
Driver bypass was 231 ohms in all cases.
1) 2k resistors for each of 2 LEDs in the tail switch (1k parallel equivalent). For a fresh battery, this gives (4.2V - 1.1V) / (1k + 231) = 2.52mA.
2) 511 ohm resistors in the tail (255.5 parallel equivalent). For the same battery, this gives (4.2V - 1.1V) / (255.5+231) = 6.37mA.
3) 231 ohm resistors in the tail (115.5 parallel equivalent). For the same battery, this gives (4.2V - 1.1V) / (115.5+231) = 8.95mA.
Using my 3400mAH battery down to nothing, this yields the following times to a paperweight: 56 days, 22 days, and 15.8 days respectively.
This isn’t exactly correct as the battery voltage will droop with use, so the current drain will be less with a partially charged battery (4.2V in the equation is actually a variable, not a constant). Maybe using 3.7 would show a more true average.
My results were that case 3 looked the best, but is pretty ridiculous in it’s battery drain. Especially if you wanted to use an 18350 instead of 18650. The 2k is really not visible with ambient light, but if the room is dark you can clearly see the blue ring.
As far as the fit in an S2+, I had to do some minor filing around 2 of the 3 switch boards I tried to use in order to fit it in. It was more taking off the imperfections in the board from where it’s mounted during manufacturing than anything else. I would say I took off less than .5mm all the way around.
I also had to change out the gasket around the “piston” of the metal S2+ switch, and replace the metal washer with a nylon one.