[2023-02-17] *OPTIONAL* traditional theme preview screenshots

Are the lines thicker? I like them, whatever they are…could be lighter or thinner I guess. j

I had another thought.

Is it possible to scooch the timeline slider thing over to the right and separate it just a bit from the topic/replies body? Maybe not fully right-aligned, but some pad space?

Some of the lines are still thin, looks kinda weird now:

This fixes it for me (on desktop):

.small-action.topic-post-visited .topic-post-visited-line {
    width: 100%;
    border-bottom: 2px solid var(--danger-medium);
}

I also bumped up the line thickness to 2px to match the regular horizontal dividers.

2 Thanks

Thanks, good catch. Those were the “time gap” lines. I think I just fixed them.

2 Thanks

@quahog
Nice!
Looks like sb adopted your change, and it looks good in my opinion! :yum:

Nice! Works great, now applied.

3 Thanks

It looks good to me!

1 Thank

Hmm that would be a bit more difficult I think. It’s a bit closer together now due to the wider post content change we applied a few days back.

Ok, no worries. I figured that might be difficult or impossible, if that size space is even usable.

I can’t get it to duplicate now in other threads but I could swear that when I reopened this thread one of the blue lines on the new posts sort of “breathed” quite a bit thicker for a couple moments (red did not, and the adjacent blues did not). Am I having a stroke?

:smiley: Impressive coincidence! That was me doing a gut check to see if I was tweaking the correct value, so I set it to a very obviously high value and then changed it back within 3 seconds. So I guess I should say “Hello world! Welcome to this live dev session.” :stuck_out_tongue_winking_eye:

1 Thank

I played around a bit with some CSS today… this is far from a finished theme, but I think it’s at least interesting as an early preview.

Any thoughts?

3 Thanks

Looks really nice!
It’s even better than the standard dark mode.
Is sb’s post green because he’s the admin?

Yes, I wanted to see how things might look with some things themed per-user… and sb was the obvious person to test that with.

It looks like there’s special markup for admins and for the OP (the original poster, the person who started the thread), so those can both be styled a little differently. The green isn’t permanent; it was just an easy color which stands out for testing.

I haven’t attempted to style anything except thread comments yet. Mostly, I just wanted to put a box around those to visually separate them from each other, make the post headers more visible, and reduce the amount of blank space so more information can fit onscreen.

Also, I’m just using a Stylus override for now… haven’t tried to set up Discourse for writing a proper theme yet. That’ll be necessary before it can be usable on the server.

I think that looks great. Easy to understand. Attractive layout.

Very cool, thanks a lot @ToyKeeper for sharing that!

Does it work for the mobile layout too? (You can add a URL parameter /?mobile_view=1 on a desktop browser.)

Is it based on the “BLF Dark” color scheme or the light one?

Discourse actually has the same sort of functionality as Stylus built into it so that the admin doesn’t have to fork / install / maintain a full-blown Discourse theme, it basically allows for overriding the CSS definitions if they’re present, otherwise it uses the base theme CSS. That way I could simply add your CSS tweaks on top of the base theme and save a lot of work creating a theme from the ground up, and since it’s implemented on top of the upstream Discourse code it will continue to receive updates from the upstream theme developers.

1 Thank

It’s just a quick sketch so far and I haven’t tried to make it work on mobile. I haven’t done much testing with it at all yet.

It’s based on the dark theme.

If you’re willing to use it on the server, and would prefer an override instead of a full theme, I can send you what I have. I’d prefer to make it more complete and robust though… like I said, this was a pretty quick sketch.

I was also thinking about submitting a patch upstream since I don’t really like any of the default themes, but I haven’t looked into how feasible that is.

Anyway, in case it helps, this is what I have so far. It’s an early draft which only themes a few page elements.

1 Thank

I’m liking this.

1 Thank

Really appreciate it TK. Yes I could definitely add the custom CSS server side to an optional user-selectable theme.

I wonder if it would be good to base it on the current theme or on the more traditional WWW theme that is being considered? Or maybe your tweaks will be mostly universally compatible with most Discourse themes, I haven’t tried it yet.

I like it

My original plan was to grab the sources for the WWW theme, the Material theme, and your version of the dark theme… to learn how to style various elements. Like, the WWW theme does a good job with the index, the Material theme has nice comment formatting, and the BLF Dark theme has good colors and some nice usability tweaks.

Then I was going to make a full Discourse theme based on the best parts of each, mixed in with some stuff from the old BLF After Dark. And … maybe also make a light version?

But that’s a heavyweight approach and I didn’t know how much work it would take, so I started poking at things in Stylus this morning to get a better feel for the markup… and it turned out to be easier than expected.

You’re welcome to use what I’ve done so far, but there’s still a lot more to do.

3 Thanks