Anduril 2 feature change suggestions

LED Flashlights – General Info
199

PSA: if you flash one of the newest (esp. from the ‘multichannel’ branch) Anduril revisions on your flashlight and think you’re going crazy, don’t worry, you’re not :wink:

Seriously, I just downloaded/configured/compiled/flashed revision 721 straight from TK on my Wurkkos FC13, and it gave me some serious head-scratching specially re: version check: it blinks the switch aux LEDs instead of the main one (no big deal, had seen it before) BUT it totally changes the blink sequence: first comes the MODEL number instead of the date (on the aux LEDs), then it ‘BUZZES’ (!) the main LED , then it blinks the year (on the aux LEDs again) plus another buzz of the main LED and then rinse and repeat for month and day.

I thought something was seriously wrong (with my flashlight or my brain or both :smiley: ) until I examined the new release’s version-check-mode.c and found it’s on purpose :wink:

Also, @wolfgirl42 and/or @ToyKeeper, you might be interested to know that the new revision (compared to eg. 654) introduces some breakage when #undef USE_SIMPLE_UI is present in the flashlight-specific cfg file (which I do to completely remove simple mode from my lights to save the flash and to have them start right at Advanced mode after every flashing/factory-reset): it leaves a ‘leading else’ on line 130 and forces the compile to abend with a syntax error. My fix was this:

--- 721/~toykeeper/flashlight-firmware/multi-channel/ToyKeeper/spaghetti-monster/anduril/channel-modes.c.orig-20230611  2023-04-26 03:39:28.000000000 -0400
+++ 721/~toykeeper/flashlight-firmware/multi-channel/ToyKeeper/spaghetti-monster/anduril/channel-modes.c        2023-06-11 20:03:39.254320591 -0400
@@ -121,19 +121,19 @@
     #if defined(USE_SIMPLE_UI)
     // remaining mappings aren't "simple", so stop here
     if (cfg.simple_ui_active) {
         return EVENT_NOT_HANDLED;
     }
-    #endif
 
     #if NUM_CHANNEL_MODES > 1
     // channel toggle menu on ... 9H?
     else if (event == EV_click9_hold) {
         push_state(channel_mode_config_state, 0);
         return MISCHIEF_MANAGED;
     }
     #endif
+    #endif
 
     return EVENT_NOT_HANDLED;
 }

Not sure if this is the correct fix, but WFM (perhaps because I don’t have multichannel? :slight_smile: )

Thank you ladies for all the great work you do with Anduril, and @wolfgirl42 specially for the assist in pointing me towards the multichannel branch when I asked about the best firmware for the FC13 on r/flashlight.

EDIT: now that I digged my old Launchpad account back out, may as well submit this as a bug to TK’s repo: Bug #2027883 “multi-channel branch: compile-time error if USE_SI...” : Bugs : Flashlight Firmware Repository

EDIT #2: Now that TK moved Anduril to Github,I’ve resubmitted this fix as a pull request: Fixes syntax errors when USE_SIMPLE_UI is undefined by DurvalMenezes · Pull Request #2 · ToyKeeper/anduril · GitHub

2 Thanks