E-switch UI Development / FSM

But mine doesn’t turn off. It steps down at exactly 3v, and when I gradually set my power supply down to 2.4v it steps down to very low mode but doesn’t turn off.

Hello TK, good folks from this thread,

Could I ask someone willing to help out to compile momentary.c for me, I need .hex file to load to mcu.
For some reason it is harder than it looks, firs fail was: “spaghetti-monster.h: No such file or directory”
then I find this header file, put it in the folder with my project, I hit rebuild AVRGCC1 and get 4 errors now,
several: expected ‘=’, or ‘,’,‘;’, ‘asm’ or ‘attribute’before ’int_fast8_t’ and
fsm-event.h: No such file or directory!
So now I download all those fsm-… files and hit Rebuild AVRGCC1 one
more time and I get 23 errors and 7 warnings !!! :weary:
If I add one more .h file I will probably get 50 errors… :frowning:
Why is this so hard :cry:


I double-checked just now. Built and flashed the latest code, and it stepped down and turned off as expected.

How long did you let it run? It has a minimum amount of time between each step-down, and some of the lower levels may not appear to change because of duplicate entries in the ramp table.

Hunter, you’ll need to check out the entire branch and set up the build environment before compiling. The build options are shown in the bin/build-85.sh script, and it needs at least the ToyKeeper/* tree of the repository in order to compile.

I don’t know the exact steps for this in a GUI like Atmel Studio, because I’ve never used one. In a terminal, though, the steps are:

  • bzr branch lp:~toykeeper/flashlight-firmware/fsm
  • cd fsm/ToyKeeper/spaghetti-monster/momentary
  • …/…/…/bin/build-85.sh momentary
  • …/…/…/bin/flash-85.sh momentary.hex

I ran it for about an hour at 2.4v and it stays at very low mode. My anduril is the latest version.

Hunter, it definitely looks like your build environment is missing some things. It can’t even find standard library components.

Unfortunately, I don’t know how to fix that, but perhaps there are answers in Hoop’s guide, Comfychair’s guide, or WarHawk-AVG’s guide?

Weird. It should activate in like 10 seconds. At least, mine did… and it was running at 2.6V.

If it’s low enough to trigger step-downs, it should also be able to trigger shutoff. I don’t have a “low” vs “critical” distinction in the code.

Maybe it’s a different version of the code, but LVP has been working since near the beginning. Maybe there’s a relevant hardware difference. IIRC a couple people mentioned the light bled a bit even while off, which would be hard to detect without measuring the mA during LVP. If it’s running at ~2 mA or higher, that probably means the MCU is still on and awake. But if it’s under 1 mA and light is still coming out, or if it never goes under ~3 mA, there may be a leak bypassing the MCU somehow.


I have had NarsilM v1.2 on my Q8 for a long time, but now I’ve flashed your new firmware anduril-q8.2018-01-24.hex
and noticed that the e-switch LED is illuminated when the lamp is turned off.

I’ve been playing around like crazy with this new firmware testing “everything” and after that the e-switch LED is no longer lit when the lamp is off.

I couldn’t figure out how to make the e-switch LED lit again while the lamp is off, so I had to re-flash the Q8 again with the same firmware anduril-q8.2018-01-24.hex and now the e-switch is illuminated again when the lamp is turned off.

My question is, how to toggle between e-switch LED behavior?

Many thanks for all your amazing work!

Isn’t Andúril great? :heart_eyes:

ToyKeeper explained switch illumination settings a few pages back:


Now you’ve got me wanting a double-sided dot matrix VFD from an IBM cash register mounted to my desk… :partying_face:

Yes it is!

Now I can switch between the different modes.
Many thanks for your reply.

TK, why is DEFAULT_THERM_CEIL defined per-UI?
Shouldn’t it depend on hardware instead?

It could be defined per-hardware instead of per-UI. Hasn’t really come up before. It’s intended to be a value that the app/UI code can use to tweak behavior of the library.

Also, there isn’t really a per-host hardware definition concept. FSM’s hardware definitions are more about the driver type than about the host or emitters.

Mostly, there hasn’t been a need yet.

I tried compiling FSM.
It doesn’t have a makefile, weird. OK, I wrote one. But then it lacks system includes.
I see no mention of the compilation process in spaghetti-monster.txt.
TK, how should I compile it?

Nearly every project had the exact same Makefile, so I converted things to a build script per MCU type. Here’s what I do to build and flash it:

> cd ToyKeeper/spaghetti-monster/anduril
> ../../../bin/build-85.sh anduril
avr-gcc -Wall -g -Os -mmcu=attiny85 -c -std=gnu99 -DATTINY=85 -I.. -I../.. -I../../.. -o anduril.o -c anduril.c
avr-gcc -Wall -g -Os -mmcu=attiny85 -o anduril.elf anduril.o
avr-objcopy --set-section-flags=.eeprom=alloc,load --change-section-lma .eeprom=0 --no-change-warnings -O ihex anduril.elf anduril.hex
Program:    7372 bytes (90.0% Full)
Data:        288 bytes (56.2% Full)
> ../../../bin/flash-85.sh anduril.hex

Thanks, I managed to compile it now. Though these scripts use some avr-size extensions from Win-AVR, I had to remove -C and —mcu. And the following grep.

BTW, have you considered refactoring temperature control out of the UI code?
The way it is now all UIs have to duplicate it.

I think, conceptually, the UI code is probably the right place to handle signals like “low voltage” and “overheating”. However, it might be nice to put the details into a shared file so it doesn’t need to be duplicated.

The base library will probably make bad choices if it tries to handle those conditions with no knowledge of what the UI is doing. Like, low voltage in strobe mode or beacon mode probably requires different handling than a steady output mode. Or, overheating in candle mode, it’ll need to modify the UI’s internal variables in order to get dimmer, since it’s constantly changing brightness. Otherwise the candle algorithm would clobber the thermal algorithm.

So I don’t have a good and clean solution yet.

I don’t think UI should do thermal regulation. The way I see it is that UI constantly changes the desired brightness. But the actual brightness would be decided elsewhere.

UI would still need to be notified about:

  • the fact that overheating started or stopped
  • the current output ceiling
  • (?) that output ceiling changed

It would also make writing UIs easier. Forgetting about things like “I should be careful entering strobe if I’m overheating” would not lead to the light being overheated in any case. Unless UI forces something like #define NO_THERMAL_CONTROL.

As to low-voltage…I’m not sure if this is the same or different than high-temperature. It is quite unusual for UI to purposefully disable thermal regulation and allow the light to overheat. However never-leave-in-the-dark logic makes as much sense as a hard limit to protect battery from inexperienced hands.
I’m leaning to thinking that it would be best to do a PID controller that tries to keep voltage above the set floor, fluidly dimming down (or brightening up, f.e. when battery warmed up to above-freezing), just like thermal regulation. With either shutoff or not when further regulation is not possible. So it would be quite similar to thermal control when it comes to interaction with UI.

BTW there’s one low-voltage protection that I’ve never seen implemented.
When you can’t regulate down anymore, turn off. But just once. If the light is turned on again, keep working.
It will protect the battery in case of accidental activation. And will act as a signal that nothing more can be done to maintain battery life.
Certainly not muggle proof, a muggle will turn it on and think it was a malfunction.
And this is not the best way to signal low-battery as it may turn off in a bad moment, f.e. during a difficult crossing.
And the best way to protect from accidental activation is to make sure such activation doesn’t happen.
So it may make no sense. But I wanted to show the idea in case someone thinks it’s actually useful. Or gets inspired to make it actually useful.