We live Rural. Nobody wants to have or pay for,
second hand lights round here.
I keep around 34ish, latest ones.
The rest. AA/AAA I give away.
18650 and others. Li Ion I wouldn’t trust (Safety wise) with most people.
I’ve just dumped quite a lot, in last 6 or 7 yrs.
Most were under $20AUD with a lot under $10ish.
So not too much wasted.
#4 and #5
For my first lights I payed retail prices in retail stores. I rather keep them than to let them go.
My newer lights I buy (ahem) cheap, so I don’t loose a fortune when the modding goes wrong.
Anyway: I don’t give away LiIon lights unless I completely trust (or terribly hate) him/her
Of course… I will keep them. Never throw away a working flashlight no matter if it is old.
Store store store them all
i just keep them, they don;t really take up all that much space
i have maybe 50 or so in a box
well maybe 2 boxes
‘usable’ and ‘old/broken’
i still buy weird or old lights at yard sales if they are cheap enough
just to remember or forget 
wle
Like many here, I’ve lost count of the number of flashlights and knives I’ve given away over the years.
Wow!
What a “flashback” in time.
Before I even read your post I said to myself, “that looks like one of those free Radio Shack lights”.
If I recall it was around 1978 or 1979 that they gave them away?
I was in high school at the time.
I was impressed with the light, especially being free, including batteries.
5 and 6
My wife asks, when I die, what’s she supposed to do with all these flashlights, batteries, and chargers.
I’m thinking ….
A while back I tried to talk MTN into accepting as donations and reselling old flashlights, but had no luck with that.
Answer: Don’t you worry your sweet little head about that. You’re going to die first.
I throw mine away, trash.
I keep them around. I have a thing for odd and unconventional (old school) lights. Like an easy chair you don’t want to part with. Some I mod and some I use for parts, but generally I don’t toss them. Even if I mess them up during modding, if fixable they get fixed. If they can’t they become parts for other lights!
If an old flashlight stills makes light all is good. What more can you ask. 